Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Idea: Validate parameters when the parameter has been changed #51

Open
nvnieuwk opened this issue Sep 3, 2024 · 4 comments
Open

Idea: Validate parameters when the parameter has been changed #51

nvnieuwk opened this issue Sep 3, 2024 · 4 comments
Labels
feature request Propose an idea for a new feature

Comments

@nvnieuwk
Copy link
Collaborator

nvnieuwk commented Sep 3, 2024

A nice feature for nf-schema would be some kind of option to make the plugin automatically check a parameter again when it has been changed.

Ideally this feature could completely replace the validateParameters function to work out of the box, but not sure if this is possible as a nextflow plugin without making the code extremely slow. This would need some testing :)

@nvnieuwk nvnieuwk added the feature request Propose an idea for a new feature label Sep 3, 2024
@bentsherman
Copy link
Member

What do you mean when a parameter has changed? I would argue that the params map should be immutable in the script, except perhaps for some initial definitions

@nvnieuwk
Copy link
Collaborator Author

nvnieuwk commented Sep 3, 2024

Yep I agree with you! But it would be nice to validate these initial changes too. The current way solves this by using a function that gets called after these are set, but I'd rather move the validation to some configuration option to in order to make it even easier to use the plugin. I'm just spitballing here so no idea if it even will be possible but it would be nice

@bentsherman
Copy link
Member

To be honest, I think even the script shouldn't be allowed to assign parameters. It is a shorthand to provide some sensible defaults in the script, but really the schema file should be the source of truth for such defaults (or a "params" block in the script but that's still just an idea).

And that way you won't have to go to all of this trouble to do dynamic validation 😉

@nvnieuwk
Copy link
Collaborator Author

nvnieuwk commented Sep 3, 2024

Also true, Default assigning has also been requested for the plugin so this would also be possible once we move to a start-of-pipeline validation (#35). But yeah this is probably some nice future thinking and it will be hard as long as params stay mutable but we'll see :p

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Propose an idea for a new feature
Projects
None yet
Development

No branches or pull requests

2 participants