Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LOGIN button missing from mobile #962

Open
victorlin opened this issue Jul 29, 2024 · 3 comments
Open

LOGIN button missing from mobile #962

victorlin opened this issue Jul 29, 2024 · 3 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@victorlin
Copy link
Member

victorlin commented Jul 29, 2024

from @joverlee521 in #952 (comment)

The "LOGIN" button is lost in mobile view because of the presence of the logo (looking at the /pathogens page).

Screenshot 2024-07-29 at 1 13 16 PM

A nice future improvement would be to collapse the nav links behind button at certain breakpoints, but for now maybe just hide the logo based on breakpoint?

@victorlin victorlin added the bug Something isn't working label Jul 29, 2024
@victorlin
Copy link
Member Author

Instead of hiding the logo, hiding the "Nextstrain" title frees up more space:

image

We'd just have to make the logo link to the homepage, which I think should be done regardless.

@PetWolowitz
Copy link

I found this issue on https://ovio.org/projects and would love to contribute!

@victorlin
Copy link
Member Author

@PetWolowitz thank you for your interest, I forgot to add the label but this is an appropriate good first issue Good for newcomers . The repo's readme has instructions on how to get things running locally – that should be a good place to get started. Let us know if you have any other questions.

@victorlin victorlin added the good first issue Good for newcomers label Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants