Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Execute syntax checks on pull requests #1023

Closed
woutdenolf opened this issue Mar 8, 2022 · 2 comments · Fixed by #1024
Closed

Execute syntax checks on pull requests #1023

woutdenolf opened this issue Mar 8, 2022 · 2 comments · Fixed by #1024
Assignees
@woutdenolf
Labels
tests Tests suite
Milestone
NXDL 2022.06

Comments

@woutdenolf
Copy link
Contributor

For a PR you will only see CI passing/failing after you already merged the PR. You want to see it before you merge the PR.
@woutdenolf woutdenolf mentioned this issue Mar 8, 2022
Merged
@woutdenolf woutdenolf changed the title Execute CI on pull requests Execute syntax checks on pull requests Mar 8, 2022
This was referenced Mar 8, 2022
Closed
Closed
@prjemian
Copy link
Contributor

prjemian commented Mar 8, 2022

Actions https://github.com/nexusformat/definitions/actions/runs/1923801265 and https://github.com/nexusformat/definitions/actions/runs/1923718922 (both for #999) are examples of CI workflows failure before the PR was merged.

@prjemian prjemian added this to the NXDL 2022.03 milestone Mar 8, 2022
@prjemian prjemian added the tests Tests suite label Mar 8, 2022
@woutdenolf
Copy link
Contributor Author

Yes but these are push events on non-main branches. You don't see this in the pull request do you?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@woutdenolf woutdenolf

Labels
tests Tests suite
Projects
None yet
Milestone
NXDL 2022.06
Development

Successfully merging a pull request may close this issue.

syntax checks for pull requests woutdenolf/definitions
2 participants
@prjemian @woutdenolf