Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adjust NXsnsevent and NXsnshisto to be consistent with #634 #821

Closed
phyy-nx opened this issue Oct 19, 2020 · 0 comments · Fixed by #825
Closed

adjust NXsnsevent and NXsnshisto to be consistent with #634 #821

phyy-nx opened this issue Oct 19, 2020 · 0 comments · Fixed by #825
Milestone
NXDL 2022.06

Comments

@phyy-nx
Copy link
Contributor

phyy-nx commented Oct 19, 2020

With the NIAC2018 decision to use VARIABLE_errors (#634) to associate uncertainties with datasets named VARIABLE, suggest changing average_value_error to average_value_errors in NXsnsevent and NXsnshisto.

This is a contributed definition, so feedback review from original authors will be appreciated.

Note the definition cites NXlog and NXpositioner. average_value_error appears twice in each of these citations. NXlog's average_value_error will be renamed as part of resolving #639. NXpositioner doesn't have average_value or averge_value_error, so this contributed definition adds these fields.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
NXDL 2022.06
Development

Successfully merging a pull request may close this issue.

NXsnsevent and NXsnshisto: deprecate _error fields nexusformat/definitions
2 participants
@prjemian @phyy-nx