Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Third umi read #11

Closed
wants to merge 5 commits into from
Closed

Third umi read #11

wants to merge 5 commits into from

Conversation

adamrtalbot
Copy link

Support for UMI sequences contained in third read, e.g. Nonacus or IDT.

  • Adds new column to samplesheet fastq_umi for UMI

Additions:

  • Writes software versions in versions.yml

Fixes:

  • Catches BWA indexes that include .64

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
    • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
    • If necessary, also make a PR on the nf-core/fastquorum branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@nh13
Copy link
Member

nh13 commented Nov 3, 2022

@adamrtalbot thanks for the submission. It's on my list to review but that may take a little while.

@nh13
Copy link
Member

nh13 commented Feb 15, 2023

@adamrtalbot : can you get the tests passing (let me know if you want me to help)?

@nh13
Copy link
Member

nh13 commented May 14, 2024

@adamrtalbot would you have a link to the protocol for both Nonacus or IDT, along with a test dataset (or datasets) we could add here: https://github.com/nf-core/test-datasets/tree/fastquorum

@adamrtalbot
Copy link
Author

adamrtalbot commented May 14, 2024

Hi @nh13, I don't have immediate access to either of those things but I can ask my former colleagues. IDT have a diagram here but limited instructions: https://www.idtdna.com/pages/support/faqs/how-do-i-sequence-the-umi-in-the-xgen-udi-umi-adapters

An existing PR for a UMI FASTQ file is here: nf-core/test-datasets#703, I will re-point this one to the fastquorum branch.

I'll take a look at updating this PR soon, sorry it fell by the wayside.

@adamrtalbot
Copy link
Author

PR for test data open here: nf-core/test-datasets#1201

@adamrtalbot
Copy link
Author

Closed in favour of #37

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants