From c2488b5218975975cc6ad4a17f5e76ef84c7c8dd Mon Sep 17 00:00:00 2001 From: "James A. Fellows Yates" Date: Wed, 18 Sep 2024 10:33:42 +0200 Subject: [PATCH 1/3] Strip hyphens from hashtags for mastodon compatibiluty --- .../.github/workflows/release-announcements.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/nf_core/pipeline-template/.github/workflows/release-announcements.yml b/nf_core/pipeline-template/.github/workflows/release-announcements.yml index 8fee061fdd..035ed63bba 100644 --- a/nf_core/pipeline-template/.github/workflows/release-announcements.yml +++ b/nf_core/pipeline-template/.github/workflows/release-announcements.yml @@ -12,7 +12,7 @@ jobs: - name: get topics and convert to hashtags id: get_topics run: | - echo "topics=$(curl -s https://nf-co.re/pipelines.json | jq -r '.remote_workflows[] | select(.full_name == "${{ github.repository }}") | .topics[]' | awk '{print "#"$0}' | tr '\n' ' ')" >> $GITHUB_OUTPUT + echo "topics=$(curl -s https://nf-co.re/pipelines.json | jq -r '.remote_workflows[] | select(.full_name == "${{ github.repository }}") | .topics[]' | awk '{print "#"$0}' | tr '\n' ' ')" | sed 's/-//g' >> $GITHUB_OUTPUT - uses: rzr/fediverse-action@master with: From bebc6bc1cdb065654a0d33e25c42e7f6e9a2ccca Mon Sep 17 00:00:00 2001 From: "James A. Fellows Yates" Date: Wed, 18 Sep 2024 13:45:44 +0200 Subject: [PATCH 2/3] Update CHANGELOG.md --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 1bcc937852..f2d494ab13 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -38,6 +38,7 @@ - add option to exclude tower.yml from pipeline template ([#3134](https://github.com/nf-core/tools/pull/3134)) - run nf-core lint `--release` on PRs to master ([#3148](https://github.com/nf-core/tools/pull/3148)) - Add tests to ensure all files are part of a template customisation group and all groups are tested ([#3099](https://github.com/nf-core/tools/pull/3099)) +- Fixed release announcement hashtags for Mastodon ([#3099](https://github.com/nf-core/tools/pull/3176)) ### Linting From 494a03ff12a45d235d2a8c62ca86d52e5de064dc Mon Sep 17 00:00:00 2001 From: mirpedrol Date: Thu, 19 Sep 2024 12:15:19 +0200 Subject: [PATCH 3/3] fix broken lint test by adding module dependency version --- tests/modules/test_lint.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/modules/test_lint.py b/tests/modules/test_lint.py index 51c814b88c..07e12924c6 100644 --- a/tests/modules/test_lint.py +++ b/tests/modules/test_lint.py @@ -432,7 +432,7 @@ def test_modules_environment_yml_file_sorted_incorrectly(self): ) as fh: yaml_content = yaml.safe_load(fh) # Add a new dependency to the environment.yml file and reverse the order - yaml_content["dependencies"].append("z") + yaml_content["dependencies"].append("z=0.0.0") yaml_content["dependencies"].reverse() yaml_content = yaml.dump(yaml_content) with open(