Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error handling for synapse 400 errors (and others) #56

Open
allaway opened this issue Feb 17, 2021 · 0 comments
Open

Error handling for synapse 400 errors (and others) #56

allaway opened this issue Feb 17, 2021 · 0 comments
Labels
bug Something isn't working

Comments

@allaway
Copy link

allaway commented Feb 17, 2021

Describe the bug
Tried to apply a manifest with invalid annotation name, synapse returns 400 error causing app to crash.

To Reproduce
This probably only works with admin override, but may also work with non-schema column names which appear to be(?) ignored by the validator. Add a column name (cell lysate is the one that revealed this bug), validate, override, upload to synapse.

Expected behavior
Expect app to not crash, but to pass error along or provide rational explanation for what happened.

Screenshots

Warning: Error in py_call_impl: SynapseHTTPError: 400 Client Error: 
Invalid annotation name: 'cell lysate'. Annotation names may only contain; letters, numbers, '_' and '.'

@allaway allaway added the bug Something isn't working label Feb 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant