Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consider standardizing RRIDs with prefix #63

Open
allaway opened this issue May 24, 2024 · 0 comments
Open

consider standardizing RRIDs with prefix #63

allaway opened this issue May 24, 2024 · 0 comments

Comments

@allaway
Copy link
Contributor

allaway commented May 24, 2024

currently, the SRC has to look for a variety of patterns to identify RRIDs: https://github.com/Sage-Bionetworks/synapse-web-monorepo/blob/9e4da441b2ab066bd2180ac071877173fe9573e5/packages/synapse-react-client/src/components/GenericCard/Linkify.tsx#L47

We shoudl consider adding the prefix RRID: and an appropriate regex rule ^RRID:[a-zA-Z]+.+$ to both the SRC and the data model so that we can validate input RRIDs, and have a simpler rule on the SRC side for finding these RRIDs. This also will allow any synapse user to define any valid RRIDs as links (currently, they can only do ones that match the linkify code above).

What do you think @cconrad8 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant