Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add variables for safety team, player and id #251

Closed
mrcaseb opened this issue Jul 7, 2021 · 2 comments · Fixed by #252
Closed

Add variables for safety team, player and id #251

mrcaseb opened this issue Jul 7, 2021 · 2 comments · Fixed by #252

Comments

@mrcaseb
Copy link
Member

mrcaseb commented Jul 7, 2021

There are some weird cases where it is not easy to get the correct safety player (which is req. for defensive player stats) so we should add that information via stat id 89 explicitly

@mrcaseb
Copy link
Member Author

mrcaseb commented Jul 7, 2021

Currently we are doing this

} else if (stat_id == 89) {
row$safety <- 1

@mrcaseb
Copy link
Member Author

mrcaseb commented Jul 7, 2021

For 2020, stat id 89 delivers 24 safeties some of which are not counted for a specific player because of plays like this:

"(9:18) (Shotgun) 1-K.Murray pass short middle to 10-D.Hopkins to ARI 10 for 8 yards (50-K.Wright). PENALTY on ARI-64-J.Sweezy, Offensive Holding, 2 yards, enforced in End Zone, SAFETY - No Play."

The overall Number of 24 and the respective teams are correct so it shopuld be fine to use stat id 89
grafik

grafik

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant