Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report ConfigMap errors when user tries to apply invalid values for the keys #6379

Open
haywoodsh opened this issue Sep 9, 2024 Discussed in #6164 · 1 comment
Open
Labels
proposal An issue that proposes a feature request

Comments

@haywoodsh
Copy link
Contributor

Discussed in #6164

We should emit config map events for all validation failures

Originally posted by jjngx August 9, 2024
This idea is a follow up of this PR: #5648

If the value for the access-log is invalid, the config map obj does not show error/warning state. The error is only visible in the NIC log, for example:

E20240809 10:59:06.679467       1 configmaps.go:212] Configmap nginx-ingress/nginx-config: Invalid value for key access-log: "ssyslog:server=localhost:514"

config-map:

...
Data
====
access-log-off:
----
true
access-log:
----
syslog:server=localhost:514
...

The main idea is to improve UX and allow users to see that objects are not applied due errors by checking (describing) the obj without a need to check NIC logs.

@haywoodsh haywoodsh added the proposal An issue that proposes a feature request label Sep 9, 2024
Copy link

github-actions bot commented Sep 9, 2024

Hi @haywoodsh thanks for reporting!

Be sure to check out the docs and the Contributing Guidelines while you wait for a human to take a look at this 🙂

Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
proposal An issue that proposes a feature request
Projects
Status: No status
Development

No branches or pull requests

1 participant