Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tracing does not work on HTTPRoutes with matching conditions #2105

Closed
sjberman opened this issue Jun 6, 2024 · 1 comment
Closed

Tracing does not work on HTTPRoutes with matching conditions #2105

sjberman opened this issue Jun 6, 2024 · 1 comment
Assignees
@sjberman
Labels
bug Something isn't working refined Requirements are refined and the issue is ready to be implemented. size/large Estimated to be completed within two weeks
Milestone
v1.4.0

Comments

@sjberman
Copy link
Contributor

sjberman commented Jun 6, 2024

Describe the bug
When using HTTPRoutes with matching conditions like headers, method, or queryParams, traffic is redirected from the external location to an internal location. Tracing does not work on this internal location. Traces must be initialized from the parent location.

To Reproduce

  1. Create an HTTPRoute with matching conditions
  2. Attach an ObservabilityPolicy to that Route

Additional context
NJS should help with creating a dynamic variable to start tracing depending on the incoming request.
@sjberman sjberman added the bug Something isn't working label Jun 6, 2024
@sjberman sjberman added this to the v1.4.0 milestone Jun 6, 2024
@sjberman sjberman mentioned this issue Jun 10, 2024
Merged
@mpstefan mpstefan added the refined Requirements are refined and the issue is ready to be implemented. label Jun 10, 2024
@mpstefan mpstefan changed the title Tracing does not work on redirected locations (HTTPRoutes with matching conditions) Tracing does not work on HTTPRoutes with matching conditions Jun 10, 2024
@mpstefan mpstefan added the size/large Estimated to be completed within two weeks label Jun 10, 2024
@sjberman sjberman self-assigned this Jun 10, 2024
@kate-osborn kate-osborn mentioned this issue Jun 11, 2024
Open
@sjberman sjberman moved this from 🆕 New to 🏗 In Progress in NGINX Gateway Fabric Jun 12, 2024
@kate-osborn kate-osborn mentioned this issue Jun 25, 2024
Closed
@kate-osborn kate-osborn mentioned this issue Jul 29, 2024
Closed
@kate-osborn
Copy link
Contributor

Closing in favor of: #2308

@github-project-automation github-project-automation bot moved this from 🏗 In Progress to ✅ Done in NGINX Gateway Fabric Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sjberman sjberman

Labels
bug Something isn't working refined Requirements are refined and the issue is ready to be implemented. size/large Estimated to be completed within two weeks
Projects
NGINX Gateway Fabric
Archived in project
Milestone
v1.4.0
Development

No branches or pull requests
3 participants
@mpstefan @sjberman @kate-osborn