Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Format endpoints based off of IP family when dynamically updating upstream servers through the N+ API #2338

Closed
kate-osborn opened this issue Aug 6, 2024 · 0 comments · Fixed by #2339
Closed

Format endpoints based off of IP family when dynamically updating upstream servers through the N+ API #2338

kate-osborn opened this issue Aug 6, 2024 · 0 comments · Fixed by #2339
Assignees
@salonichf5
Labels
bug Something isn't working refined Requirements are refined and the issue is ready to be implemented.
Milestone
v1.4.0

Comments

@kate-osborn
Copy link
Contributor

kate-osborn commented Aug 6, 2024 •
edited
Loading

When we added support for ipv6 endpoints, we forgot to update this function. It’s used when we update the upstream servers through the N+ API.

We need to format the endpoints differently when they are ipv6. Like we do here:

nginx-gateway-fabric/internal/mode/static/nginx/config/upstreams.go

Line 70 in 9840a51

for idx, ep := range up.Endpoints {

@kate-osborn kate-osborn added the bug Something isn't working label Aug 6, 2024
@salonichf5 salonichf5 self-assigned this Aug 6, 2024
@salonichf5 salonichf5 added this to the v1.4.0 milestone Aug 6, 2024
@salonichf5 salonichf5 mentioned this issue Aug 7, 2024
Merged
6 tasks
@mpstefan mpstefan added the refined Requirements are refined and the issue is ready to be implemented. label Aug 7, 2024
@github-project-automation github-project-automation bot moved this from 👀 In Review to ✅ Done in NGINX Gateway Fabric Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@salonichf5 salonichf5

Labels
bug Something isn't working refined Requirements are refined and the issue is ready to be implemented.
Projects
NGINX Gateway Fabric
Archived in project
Milestone
v1.4.0
Development

Successfully merging a pull request may close this issue.

update upstreams to format ipv6 adddress for nginx plus salonichf5/nginx-gateway-fabric
3 participants
@mpstefan @kate-osborn @salonichf5