Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(Example): add cypress tests #1565

Merged
merged 11 commits into from
Feb 25, 2019
Merged

test(Example): add cypress tests #1565

merged 11 commits into from
Feb 25, 2019

Conversation

timdeschryver
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[x] CI related changes
[ ] Documentation content changes
[x] More tests

What is the current behavior?

Closes #1556

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

Copy link
Member

@brandonroberts brandonroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, what do you think about deleting the example-app-e2e folder? We don't need two e2e test suites.

"example:build:prod": "yarn example:build -- --base-href \"/platform/example-app/\"",
"ci": "yarn run test && nyc report --reporter=text-lcov | coveralls",
"example:server": "node build/example-app-server",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move this into the group with the other example: scripts

@brandonroberts
Copy link
Member

Also, is there a way to make this run with Bazel?

@timdeschryver
Copy link
Member Author

I'm agreeing to remove the existing e2e folder (and the existing config).
I'm not sure on how to run this with Bazel, or if this is possible at the moment but I can try it 😄

@brandonroberts
Copy link
Member

We're blocked on the Bazel part bazelbuild/rules_typescript#261. Once the old config is removed, everything else LGTM

@ngrxbot
Copy link
Collaborator

ngrxbot commented Feb 20, 2019

Preview docs changes for 83c5784 at https://previews.ngrx.io/pr1565-83c5784/

@@ -83,10 +83,12 @@ jobs:
- run: yarn run ci
- run: yarn run example:build:prod
- run: yarn run example:test --watch=false
- run: yarn run example:cypress:ci
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should move the example app ones into a separate job and leave this one for unit tests.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've also moved yarn run example:build:prod to the separate job, because we need this in order to run the e2e tests 😄

@ngrxbot
Copy link
Collaborator

ngrxbot commented Feb 25, 2019

Preview docs changes for 163dc75 at https://previews.ngrx.io/pr1565-163dc75/

@brandonroberts brandonroberts merged commit 383e6b2 into master Feb 25, 2019
@brandonroberts brandonroberts deleted the pr/example-cypress branch February 25, 2019 17:37
@coveralls
Copy link

Coverage Status

Coverage remained the same at 89.43% when pulling 163dc75 on pr/example-cypress into 8532fb1 on master.

tja4472 pushed a commit to tja4472/platform that referenced this pull request Mar 20, 2019
@timdeschryver timdeschryver restored the pr/example-cypress branch March 27, 2019 21:35
@timdeschryver timdeschryver deleted the pr/example-cypress branch March 27, 2019 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Example: add cypress testing for example app
4 participants