Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Define code review #38

Open
ChrisBeeley opened this issue Sep 12, 2022 · 2 comments
Open

Define code review #38

ChrisBeeley opened this issue Sep 12, 2022 · 2 comments
Labels
content New or amend content of book

Comments

@ChrisBeeley
Copy link
Member

It may be useful to have a formal definition of code review. Here are some links I stole from the ever helpful Jess Morley.
https://www.ncbi.nlm.nih.gov/pmc/articles/PMC9367192/
https://academic.oup.com/aje/article/190/10/2172/6218064?login=false
https://google.github.io/eng-practices/review/reviewer/

@tomjemmett may find this issue interesting
@ChrisBeeley
Copy link
Member Author

Another link from the also ever helpful Jonny Pearson

https://best-practice-and-impact.github.io/qa-of-code-guidance/checklists.html

@Lextuga007 Lextuga007 added the content New or amend content of book label May 11, 2023
@Lextuga007
Copy link
Member

Best placed in this section perhaps where I've started to expand on review as interpreted from the NHSx Open policy and code review with the new book from Posit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
content New or amend content of book
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ChrisBeeley @Lextuga007