Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabled Webkit wafer map tests due to OffscreenCanvas #2169

Open
m-akinc opened this issue Jun 6, 2024 · 4 comments
Open

Disabled Webkit wafer map tests due to OffscreenCanvas #2169

m-akinc opened this issue Jun 6, 2024 · 4 comments
Assignees

Comments

@m-akinc
Copy link
Contributor

m-akinc commented Jun 6, 2024

🧹 Tech Debt

The wafer map uses the OffscreenCanvas feature that was added to Safari in version 17, but is explicitly disabled in the WebKit build (see collapsed comment) for Windows/Linux platforms. The WebKit commit for the OffscreenCanvas feature confirms this (see LayoutTests/platform/win/TestExpectations).

Therefore, we had to disable any wafer map tests that exercise OffscreenCanvas code in WebKit:

  • nimble-components/build/generate-workers/source/tests/matrix-renderer.spec.ts (all tests)
  • nimble-components/src/wafer-map/tests/create-matrix-renderer.spec.ts (all tests)
  • nimble-components/src/wafer-map/tests/hover-handler.spec.ts (all tests)
  • nimble-components/src/wafer-map/tests/wafer-map.spec.ts:
    • "will call setupWafer and drawWafer after supported diesTable change"
    • "worker renderer action" describe block
    • "can still zoom after canvas height was changed"
    • "can still zoom after canvas width was changed"
@m-akinc m-akinc added tech debt triage New issue that needs to be reviewed labels Jun 6, 2024
@rajsite
Copy link
Member

rajsite commented Jun 6, 2024

If I'm reading microsoft/playwright#31004 right should we should expect OffscreenCanvas support in the next playwright release?

@m-akinc
Copy link
Contributor Author

m-akinc commented Jun 6, 2024

Hopefully, but it's hard to tell for sure. You think we should leave the tests enabled until next quarter's manual maintenance pass?

@rajsite
Copy link
Member

rajsite commented Jun 7, 2024

Makes sense they were disabled in #2171 so those who do try and test in WebKit don't hit unexpected issues. Added a note to teh recurring playwright task to double check this issue and see if the tests can be re-enabled.

@mxschmitt
Copy link

Might be relevant: It should be also fixed in our Canary releases.

@m-akinc m-akinc removed the triage New issue that needs to be reviewed label Jun 11, 2024
@jattasNI jattasNI self-assigned this Sep 5, 2024
@jattasNI jattasNI moved this from Backlog to In Progress in Nimble Design System Priorities Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: In Progress
Development

No branches or pull requests

4 participants