don't initialize body scroll when in fastboot #187
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
so turns out this doesn't yet work. Here's a minimal representation of the issue. https://github.com/jamemackson/ember-mobile-menu-fastboot-example @nickschot any chance you can take a peek and give me a nudge in the right direction? |
nickschot
reviewed
Dec 1, 2021
Comment on lines
+17
to
+20
| fastboot = getOwner(this).lookup('service:fastboot'); | ||
| get isFastBoot() { | ||
| return !!this.fastboot?.isFastBoot; | ||
| } |
There was a problem hiding this comment.
Suggested change
| fastboot = getOwner(this).lookup('service:fastboot'); | |
| get isFastBoot() { | |
| return !!this.fastboot?.isFastBoot; | |
| } | |
| get fastboot() { | |
| return getOwner(this).lookup('service:fastboot'); | |
| } | |
| get isFastBoot() { | |
| return !!this.fastboot?.isFastBoot; | |
| } |
To be in line with the updated syntax on master.
|
@nickschot would it be possible to get this merged? Im also seeing this in fastboot. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses a " TypeError: window.addEventListener is not a function" error when using ember-mobile-menu under fastboot by preventing the body-scroll-lock library from initializing when running on the server where window isn't defined.
Error & start of stack trace...
Fixes #186