Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify with popover API? #809

Open
NullVoxPopuli opened this issue Nov 27, 2023 · 3 comments
Open

Simplify with popover API? #809

NullVoxPopuli opened this issue Nov 27, 2023 · 3 comments

Comments

@johanrd
Copy link
Contributor

johanrd commented Dec 1, 2023

Yes, this seems like a nice path! Though, I guess it may be wise to wait for firefox to enable it by default.

@nickschot
Copy link
Owner

This would probably also fix where our a11y is currently lacking (no built-in connection between the toggle button and the menu)

@johanrd
Copy link
Contributor

johanrd commented Mar 16, 2024

I was tempted to try it out a bit now, as I have very good experience with the popover api so far for other use cases (except this extremely silly safari bug).

Notes after trying: The use cases fit generally well for ember-mobile-menu, except popover's superpower of being placed in the browser top-layer means that ember-mobile-menu needs a different approach to shadowing and masking to support e.g. the iOS style where the menu is underneath:

Screenshot 2024-03-16 at 13 08 00

This could of course be solvable with some masking and inset shadow, but posting as a note to consider anyways.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants