Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support contextual comments for translations #8

Closed
nicksnyder opened this issue May 28, 2014 · 7 comments · Fixed by #92
Closed

Support contextual comments for translations #8

nicksnyder opened this issue May 28, 2014 · 7 comments · Fixed by #92
Assignees
Milestone

Comments

@nicksnyder
Copy link
Owner

Comments are useful for translators so they can understand additional context about the translation.

{
  "id": "helloName",
  "translation": "Hello {{name}}",
  "comment": "This is a welcome message for a user. {{name}} is the user's first name."
}
@nicksnyder nicksnyder added this to the v1 milestone May 28, 2014
@parkr
Copy link
Collaborator

parkr commented Aug 26, 2015

I dig this. Need any help here?

@nicksnyder nicksnyder assigned nicksnyder and unassigned nicksnyder Aug 29, 2015
@nicksnyder
Copy link
Owner Author

@parkr I haven't started working on this and probably won't anytime soon. Would you like to do this?

@abourget
Copy link

How complex can that be ?!

@abourget
Copy link

I could give it a shot if it's just adding a field to a struct :)

@nicksnyder
Copy link
Owner Author

@abourget It might be more complicated than simply adding a field to the struct. I forget why I didn't just do this to begin with. Feel free to work on this and submit a pull request.

@nicksnyder nicksnyder removed this from the v1 milestone Jan 9, 2016
@nicksnyder nicksnyder added the accepting PRs Pull requests from the community that solve this problem would be appreciated. label Oct 3, 2016
@nicksnyder nicksnyder added this to the v2 milestone Feb 14, 2018
@nicksnyder nicksnyder removed the accepting PRs Pull requests from the community that solve this problem would be appreciated. label Feb 14, 2018
@nicksnyder nicksnyder self-assigned this Apr 10, 2018
@nicksnyder
Copy link
Owner Author

This will be possible in v2. See also #92

@nicksnyder nicksnyder mentioned this issue Apr 10, 2018
Merged
4 tasks
@nicksnyder
Copy link
Owner Author

I just tagged 2.0.0.beta.1. Please start using it and report any issues that you have.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants