Skip to content
This repository has been archived by the owner on Oct 11, 2020. It is now read-only.

ublock update data bases broken. + no language selection. #18

Closed
mysterieworld opened this issue Oct 6, 2016 · 4 comments · Fixed by #21
Closed

ublock update data bases broken. + no language selection. #18

mysterieworld opened this issue Oct 6, 2016 · 4 comments · Fixed by #21

Comments

@mysterieworld
Copy link

Read first: https://github.com/gorhill/uBlock/blob/master/CONTRIBUTING.md

Describe the issue

When choose a data base, the plugin freeze, but does not update.
You can still click on a other setting, but it will not update the data bases.

Beside of that, why you cannot choose your own language, it's using my own language. But Prefer English.

One or more specific URLs where the issue occurs

[URL(s) for issue on a specific site are mandatory]

Screenshot in which the issue can be seen

image

[Screenshot(s) for visual issues are mandatory]

Steps for anyone to reproduce the issue

Just choose a database, and apply/update

  1. Be as detailed as possible:
  2. Because we are not looking over your shoulder and
  3. Keep in mind: Nobody can read your mind.

Your settings

[If you fail to provide this info, I will mark the issue as invalid. Lists all settings which differs from default settings]

  • Browser/version: Latest public Microsoft Edge Release
  • uBlock Origin version: 1.9.11.101
Your filter lists

[Example: "Default filter lists + FRA", or "Default filter lists minus uBlock -- Badware risks"]

Your custom filters (if any)
@nicole-ashley
Copy link
Owner

This appears to be an intermittent issue not with the build but with the installation. If you remove the extension and re-install it, there's about a 50/50 chance that it will resolve itself.

It's actually still working, and if you continue to refresh this page you will see it update. The only thing that's broken is the message from the background process to the UI telling it to update the progress bar. I'm looking into it.

@japborst
Copy link

japborst commented Oct 6, 2016

Been investigating this today actually. It does indeed update perfectly.

It appears that the issue arises from an error of vAPI.message.broadcast in vAPi-background.js. Edge throws a 'handle is invalid error' after the postMessage method is called.

@nicole-ashley
Copy link
Owner

The thing I find odd is that it seems to be related to the install. 25-33% of the time you get an install where this progress bar works 100% of the time. With other installs it doesn't work ever. But it never changes between installs.

@japborst
Copy link

japborst commented Oct 7, 2016

@nikrolls Interesting. For me the behaviour was: first time it works flawlessly, afterwards it hangs. But we can say it is definitely a communication issue, so perhaps we can force it through a workaround.

Regarding language selection, @mysterieworld, this should be implemented in the original repo. However it doesn't seem it'll be here anytime soon; see uBlock#241. Changing your browser language will solve though.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants