Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Glucose Distribution" report doesn't finish rendering without data #5190

Closed
steve8x8 opened this issue Nov 8, 2019 · 5 comments
Closed

Comments

@steve8x8
Copy link

steve8x8 commented Nov 8, 2019

Describe the bug
With only BG measurements available (CGM temporarily unavailable), rendering the "glucose distribution" view doesn't finish

To Reproduce
Steps to reproduce the behavior:

  1. Run out of CGM sensors for a few days.
  2. Select a time span short enough in Reports
  3. Select "Show" or "Distribution"
  4. Wait for "Rendering..." to disappear

Expected behavior
There should be a detection whether (enough) data are available at all.

Screenshots

Your setup information

  • What version of Nightscout - 0.12.6-dev
  • What type of CGM, and how do you get your data there? - currently none
  • Is your issue specific to a browser (Firefox/Safari/Chrome?) or a device (Android phone, etc.)? - No.

Additional context
Any previously drawn pie diagram isn't erased while (not) "rendering..."

@jpcunningh
Copy link
Collaborator

@steve8x8, this should also be fixed by #5195. Please let us know if it works for you.

@steve8x8
Copy link
Author

Unfortunately I cannot test it right away (you're referring to the 2nd of the 3 commits, I presume) - but lgtm. Go ahead...

@steve8x8
Copy link
Author

Update: although the server claims to be running dev 534c443, I cannot see any change :(

@sulkaharo
Copy link
Member

sulkaharo commented Nov 12, 2019

@steve8x8 are you self-hosting? If yes, remember to run the packaging script between installs / updates. Npm install does this

@steve8x8
Copy link
Author

I'm not self-hosting (yet) so I must believe what the interface and the server admin tell me...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants