Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Localize month name in timeline #897

Closed
sulkaharo opened this issue Sep 2, 2015 · 8 comments
Closed

Localize month name in timeline #897

sulkaharo opened this issue Sep 2, 2015 · 8 comments
Assignees

Comments

@sulkaharo
Copy link
Member

The timeline uses English for month names regardless of the language.

@MilosKozak
Copy link
Contributor

where?

@sulkaharo
Copy link
Member Author

The timeline at the bottom of the site.

screen shot 2015-09-02 at 16 05 12

@sulkaharo
Copy link
Member Author

Do we use moment.js for that? AFAIK Moment comes with pre-localized month names AND uses same format for the locale, so we could just pass the language ID to moment and get local names out.

@MilosKozak
Copy link
Contributor

we had an issue with moment locales. they must be loaded from a localization file. currently we don't know how to make it with browserify
so far we use pure js .toLocaleString() to get localized strings

@MilosKozak
Copy link
Contributor

new Date().toLocaleString('cs', { month: "long" });
this works
but we should localize whole timeline not only months

@jasoncalabrese
Copy link
Member

think that is all done with d3, but there's a way to override it like like we do with the time format

@jasoncalabrese
Copy link
Member

@MilosKozak MilosKozak self-assigned this Sep 5, 2015
@MilosKozak
Copy link
Contributor

solved by #1097

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants