Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

attempt to prevent pebble to only read SGV values #200

Merged
merged 2 commits into from
Oct 21, 2014

Conversation

bewest
Copy link
Member

@bewest bewest commented Oct 16, 2014

Try to avoid reporting null for pebble by only considering SGV
records.

Many thanks to @ELUTE for raising flags on this.

Try to avoid reporting null for pebble by only considering SGV
records.

Many thanks to @ELUTE for raising flags on this.
Fixes a bug where panning would show "HIGH".
@jasoncalabrese
Copy link
Member

@bewest I'm not sure about the mmol fix, there some confusing stuff going on there with the y and sgv fields. I'm going to port the pebble fix over to dev now, don't have time to test the mmol fix now

            data = d[0].map(function (obj) {
                return { date: new Date(obj.x), y: obj.y, sgv: scaleBg(obj.y), direction: obj.direction, color: sgvToColor(obj.y), type: 'sgv'}
            });

@jasoncalabrese
Copy link
Member

cherry-picked 5ed76b6 to dev

@bewest
Copy link
Member Author

bewest commented Oct 17, 2014

Looks ok, should work with my fixes.

What I observed is that foo.y is the original mg/dL value, while foo.sgv is
a string after conversion.

-bewest

On Thu, Oct 16, 2014 at 11:48 PM, Jason Calabrese [email protected]
wrote:

cherry-picked 5ed76b6
5ed76b6
to dev


Reply to this email directly or view it on GitHub
#200 (comment)
.

@jasoncalabrese
Copy link
Member

Tested was able to reproduce without this fix and verify the fix worked

jasoncalabrese added a commit that referenced this pull request Oct 21, 2014
attempt to prevent pebble to only read SGV values
@jasoncalabrese jasoncalabrese merged commit 9b5ef3c into dev Oct 21, 2014
@jasoncalabrese jasoncalabrese deleted the wip/fix-null-pebble branch October 21, 2014 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants