Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

some azure tweaks #215

Merged
merged 7 commits into from
Nov 1, 2014
Merged

some azure tweaks #215

merged 7 commits into from
Nov 1, 2014

Conversation

bewest
Copy link
Member

@bewest bewest commented Oct 31, 2014

Thanks to @shanselman, we now have several tweaks to improve Azure experience.

bewest and others added 7 commits October 31, 2014 10:43
When deployed on MS azure, the available git commit used to deploy the
software is available in the SCM_COMMIT_ID environment variable.
We encourage all hosting providers to provide some similar facility to
avoid spawning spurious processes.

Thanks to @shanselman for reminders and pointers to the fix.
Forcing SSL for Azure
Node Debugging Support for Azure
Correct Git Attributes
Node web.config for Azure, and removed it from gitignore
Enabling Websockets if they are on. Need to confirm if they need to be
turned on manually.
Counter-intuitively this needs to be FALSE so IIS can let go of
websockets and node can take over.
Forcing SSL for Azure PLUS adding WebSockets support
@bewest bewest mentioned this pull request Oct 31, 2014
@jasoncalabrese
Copy link
Member

👍

@jasoncalabrese
Copy link
Member

On my Digital Ocean server I have NGINX proxying to Node and needed to add a some settings to the config to get sockets to work. Before I did that there was a little bit of a lag waiting on failover

This is what I added to my location block:

    proxy_http_version 1.1;
    proxy_set_header Upgrade $http_upgrade;
    proxy_set_header Connection "upgrade";

We should test this with Heroku too, I'll try later today or tonight if no one beats me too it

@jasoncalabrese
Copy link
Member

Working on Heroku with no changes, think this will be ok for everyone

jasoncalabrese added a commit that referenced this pull request Nov 1, 2014
@jasoncalabrese jasoncalabrese merged commit 9e38a53 into release/0.5.0 Nov 1, 2014
@shanselman
Copy link
Contributor

@jasoncalabrese Yes, that's an Nginx detail. Socket.io simply falls back in ordinary situations. Glad it works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants