Merging latest wip/api-modules changes #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes causes the server to crash if the API_SECRET environment variable has a value whose length is less than MIN_PASSPHRASE_LENGTH characters. The default MIN_PASSPHRASE_LENGTH is 12, so if the API_SECRET variable is set but less than 12 characters long, the server will crash. security/privacy review needed ============================== The API_SECRET is used as a pass phrase in order to generate a unique token. The api routes always try to mount themselves. Before mounting sensitive routes that allow modifying the application, the secret token is required to validate the request, or denied. When the secret token is absent, the sensitive routes should return 404, and should not be mounted. This change attempts to eliminate some dangerous middle ground between having a secured api, having a weakly secured api, believing a secure api is mounted and working when none is, and not having a secure api mounted. The only choices available should be: * secure api mounted * secure api not mounted This change hopefully constrains the possibilities to those two options.
Also some minor clean up of log output during tests.
brianhanifin
added a commit
that referenced
this pull request
Jul 23, 2014
Merging latest wip/api-modules changes
sulkaharo
pushed a commit
that referenced
this pull request
Aug 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.