Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wip/bwp improvements #959

Merged
merged 2 commits into from
Sep 6, 2015
Merged

Conversation

sulkaharo
Copy link
Member

Hopefully a bit clearer messaging when <0 BWP is shown


for (var i = 0; i < sbx.data.treatments.length; i++) {
var treatment = sbx.data.treatments[i];
var delta = now - treatment.mills;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@codecov-io
Copy link

Current coverage is 83.73%

Merging #959 into dev will decrease coverage by -0.06% as of fb2b6e3

@@              dev    #959   diff @@
=====================================
  Files          61      61       
  Stmts        4295    4315    +20
  Branches        0       0       
  Methods         0       0       
=====================================
+ Hit          3599    3613    +14
  Partial         0       0       
- Missed        696     702     +6

Review entire Coverage Diff as of fb2b6e3


Uncovered Suggestions

  1. +0.27% via .../js/profileeditor.js#324...335
  2. +0.25% via .../js/profileeditor.js#269...279
  3. +0.23% via lib/hashauth.js#27...36
  4. See 7 more...

Powered by Codecov. Updated on successful CI builds.

@jasoncalabrese
Copy link
Member

I've been using that new times module, for the time constants. Like times.mins(60).msecs, before we had a bunch of constants with different names/values.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants