ES6 module import has been broken by #3774

[ert78gb]

Description of the bug/issue

Our projects use es6 module. Upgrading nightwatch 3.0.1 => 3.1.0 our test are failed.
The reason is the typescript does not transpile correctly the lib/utils/requireModule.js file.
The typescript compilation had been introduced with #3774 PR
The issue is still exists in the 3.1.2 version

The bogus transpiled code

if (getNodeVersion() >= 14) {
    const { pathToFileURL } = require('node:url');
    return Promise.resolve(`${pathToFileURL(fullpath).href}`).then(s => __importStar(require(s))).then(result => {
        const _default = result.default || {};
        return Object.keys(result).reduce((prev, val) => {
            if (val !== 'default') {
                prev[val] = result[val];
            }
            return prev;
        }, _default);
    });
}

The __importStar(require(s)) the typescript version uses the require.

I tried

• upgrade typescript to 5.1.6 but it did not help
• the "esModuleInterop": false typescript compiler option did not help

The only solution that came into my mind is copy the file to the dist folder after the ts build in the postbuild script.
The PR that I opened #3858
I hope you will find smarter solution.

Steps to reproduce

1. Go to '...'
2. Click on '...'
3. Scroll down to '...'
4. See error

Sample test

No response

Command to run

No response

Verbose Output

No response

Nightwatch Configuration

No response

Nightwatch.js Version

3.1.0

Node Version

No response

Browser

No response

Operating System

No response

Additional Information

No response

[garg3133]

@ert78gb Based on the discussion in microsoft/TypeScript#43329, I think changing module config in tsconfig.json to Node16 would be the right way to fix this.

Additional info on the change:

• https://www.typescriptlang.org/tsconfig#node16nodenext-nightly-builds
• First point of https://www.typescriptlang.org/tsconfig#moduleResolution

[ert78gb]

@garg3133 Thx. I updated the PR. It solves the issue.