You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I didn't see an issues section of the nightwatch-mocha repo (beatfactor/mocha.git), but when I npm install a project that uses the latest nightwatch ([email protected]) there are some warnings that should be addressed.
npm WARN deprecated [email protected]: Jade has been renamed to pug, please install the latest version of pug instead of jade
npm WARN deprecated [email protected]: graceful-fs v3.0.0 and before will fail on node releases >= v7.0. Please update to graceful-fs@^4.0.0 as soon as possible. Use 'npm ls graceful-fs' to find it in the tree.
Those look like they could be addressed by changing the dep inside the nightwatch repo:
Also another thing I noticed, after cloning the beatfactor/mocha repo, its unable to run its own test suite:
$ make test
lib/nightwatch/client.js
3:40 error Identifier 'test_settings' is not in camel case camelcase
6:2 error Identifier 'test_settings' is not in camel case camelcase
9:29 error The function binding is unnecessary no-extra-bind
lib/overrides/runnable.js
76:18 error Expected '===' and instead saw '==' eqeqeq
82:75 error A space is required after ',' comma-spacing
85:8 error Extra space after key "name" key-spacing
86:8 error Extra space after key "module" key-spacing
92:18 error Expected '===' and instead saw '==' eqeqeq
100:18 error Expected '===' and instead saw '==' eqeqeq
100:42 error Expected '===' and instead saw '==' eqeqeq
104:18 error Expected '===' and instead saw '==' eqeqeq
lib/overrides/runner.js
11:2 error Extra space after key "constructor" key-spacing
14:44 error Identifier 'test_settings' is not in camel case camelcase
17:54 error Identifier 'test_settings' is not in camel case camelcase
lib/runner.js
378:2 warning Expected a conditional expression and instead saw an assignment no-cond-assign
✖ 15 problems (14 errors, 1 warning)
and
$ make test-bdd
/Users/dm/src/mocha-nightwatch/lib/nightwatch/client.js:6
test_settings.output = false;
^
TypeError: Cannot set property 'output' of undefined
at new Nightwatch (/Users/dm/src/mocha-nightwatch/lib/nightwatch/client.js:6:24)
at Runner.run (/Users/dm/src/mocha-nightwatch/lib/overrides/runner.js:17:16)
at Mocha.run (/Users/dm/src/mocha-nightwatch/lib/mocha.js:459:17)
at Object.<anonymous> (/Users/dm/src/mocha-nightwatch/bin/_mocha:402:16)
at Module._compile (module.js:413:34)
at Object.Module._extensions..js (module.js:422:10)
at Module.load (module.js:357:32)
at Function.Module._load (module.js:314:12)
at Function.Module.runMain (module.js:447:10)
at startup (node.js:146:18)
at node.js:404:3
make: *** [test-bdd] Error 1
The text was updated successfully, but these errors were encountered:
I didn't see an issues section of the nightwatch-mocha repo (beatfactor/mocha.git), but when I
npm install
a project that uses the latest nightwatch ([email protected]) there are some warnings that should be addressed.Those look like they could be addressed by changing the dep inside the nightwatch repo:
and
Also another thing I noticed, after cloning the beatfactor/mocha repo, its unable to run its own test suite:
and
The text was updated successfully, but these errors were encountered: