Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Species doesn't seem to be working in review page #1

Open
ACharbonneau opened this issue Oct 28, 2021 · 0 comments
Open

Species doesn't seem to be working in review page #1

ACharbonneau opened this issue Oct 28, 2021 · 0 comments

Comments

@ACharbonneau
Copy link
Contributor

@ACharbonneau commented on Thu Oct 28 2021

I submitted a dataset where every subject is labeled as human, and it is displaying properly in the data browser:
image

but my review page says all my subjects are Not Specified

image


@mschor commented on Thu Oct 28 2021

I know this doesn't seem helpful, but it works when I hit the page. @karlcz, I don't have a good handle on how someone gets back species data from deriva. Do Amanda's posts look correct to you? When I hit the DCC Review page, it looks like this:

Screen Shot 2021-10-28 at 1 43 34 PM


@karlcz commented on Thu Oct 28 2021

I think this is probably a bug in the ingest process, as I see blank species info in the "level1_stats" table that is driving these charts.


@karlcz commented on Thu Oct 28 2021

Digging deeper, I think this is working as designed and you just have absurdist test data. You've combined the taxonomic term for homo sapiens as a pathogen in a microbiome subject!

The definition of species we are using for the stats and charts only considers a narrow profile where the subject has granularity=single organism and has exactly one taxon specified, which is for clade=species, role=single organism.


@ACharbonneau commented on Thu Oct 28 2021

Amanda needs to fix her script.

actually I think this is just a quirk of your synthetic data! you have granularity set to "microbiome" and role set to "pathogen".
Our definition for the derived "subject species" concept is to only consider taxonomy as species when multiple conditions hold:
the subject has granularity "single organism" (violated here)
the subject-role-taxonomy association is for role "single organism"
the taxonomic term has clade "species" (violated here)
there is exactly 1 such term for the subject

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant