Fatal error when trying to recover from specific code snippet

[Gert-dev]

Hello

I'm receiving a multitude of warnings and a fatal error from the PHP parser when trying to parse the following (erroneous) code with php-parse Test.php -r -P (i.e. with error recovery enabled):

<?php

function foo()
{
    return $this->arrangements->filter(function (LodgingArrangement $arrangement) {
        return   
    })->first(); 
}

The following output is generated:

PHP Notice:  Undefined offset: 27 in /home/user/core/vendor/nikic/php-parser/lib/PhpParser/ParserAbstract.php on line 318
PHP Notice:  Undefined offset: 27 in /home/user/core/vendor/nikic/php-parser/lib/PhpParser/ParserAbstract.php on line 274
PHP Fatal error:  Uncaught Error: Unsupported operand types in /home/user/core/vendor/nikic/php-parser/lib/PhpParser/Parser/Php7.php:1395
Stack trace:
#0 /home/user/core/vendor/nikic/php-parser/lib/PhpParser/ParserAbstract.php(262): PhpParser\Parser\Php7->reduceRule145()
#1 /home/user/core/vendor/nikic/php-parser/lib/PhpParser/Parser/Multiple.php(50): PhpParser\ParserAbstract->parse('<?php\n\nfunction...', Object(PhpParser\ErrorHandler\Collecting))
#2 /home/user/core/vendor/nikic/php-parser/lib/PhpParser/Parser/Multiple.php(31): PhpParser\Parser\Multiple->tryParse(Object(PhpParser\Parser\Php7), Object(PhpParser\ErrorHandler\Collecting), '<?php\n\nfunction...')
#3 /home/user/core/vendor/nikic/php-parser/bin/php-parse(61): PhpParser\Parser\Multiple->parse('<?php\n\nfunction...', Object(PhpParser\ErrorHandler\Collecting))
#4 {main}
  thrown in /home/user/core/vendor/nikic/php-parser/lib/PhpParser/Parser/Php7.php on line 1395

Expected output: some sort of error node or nothing at all if error recovery fails, but not a fatal PHP error and warnings.

This is happening with php-parser 3.0.4 on PHP 7.1.2.

Thanks in advance

[nikic]

I can confirm that this issue exists on v3.0.4. However, it is not present on HEAD of 3.x. Presumably this was fixed as part a side-effect of #359.

[nikic]

I've published a new release for 3.x, which includes the referenced patches: https://github.com/nikic/PHP-Parser/releases/tag/v3.0.5

[Gert-dev]

Doh, I've literally just released a new version of my package with the specific Git commit and came here to report that it is indeed fixed. No problem though, now I'll be able to lock Composer to a specific version again instead of a commit. Keep up the great work! 👍