Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support rebuild FastlaneSwiftRunner project on CI/CD platforms #386

Open
vnntsu opened this issue Nov 10, 2022 · 4 comments
Open

Support rebuild FastlaneSwiftRunner project on CI/CD platforms #386

vnntsu opened this issue Nov 10, 2022 · 4 comments

Comments

@vnntsu
Copy link
Contributor

vnntsu commented Nov 10, 2022

Why

  • Currently, we ignore the file FastlaneRunner which is containing executable commands for Fastlane.
  • On CI/CD machine, it needs to rebuild the FastlaneSwiftRunner project to have the latest FastlaneRunner before doing any tasks.
  • It could be a script, so Bitrise or GitHub Actions can use for rebuilding.

Who Benefits?

@nimblehq/ios-chapter

@blyscuit
Copy link
Collaborator

The issue seems to be because the flag --disable_runner_upgrades, we can run fastlane swift on CI without the flag.
I think what we need is a document for related the error when running locally without --disable_runner_upgrades and a guide on how to compile FastlaneRunner locally.

@blyscuit
Copy link
Collaborator

This commit I removed FastlaneRunner from git and remove the flag, FastlaneRunner compiles on CICD and the workflow runs smoothly.

@vnntsu
Copy link
Contributor Author

vnntsu commented Nov 10, 2022

@blyscuit Do you mean no need for any script to rebuild FastlaneRunner?

@blyscuit
Copy link
Collaborator

On CICD, we don't need the script because FastlaneRunner will be rebuild if we don't include the flag disable_runner_upgrades.
On local machine, I'm still figuring out why it is failing.
I think the only use for the script is for the local user to run it without opening the Xcode project for FastlaneRunner, but that'd be introducing a new point of failure ie: if the script fail because fastlane change its implementation with he script. So in the long run we shouldn't rely on the script. Still, adding it now wouldn't hurt.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants