Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: .env file is used by the Build Docker Production image and Deploy to AWS workflows #353

Open
malparty opened this issue Aug 12, 2022 · 0 comments
Open

Fix: .env file is used by the Build Docker Production image and Deploy to AWS workflows #353

malparty opened this issue Aug 12, 2022 · 0 comments
Labels
type : bug

Comments

@malparty
Copy link
Member

malparty commented Aug 12, 2022 •
edited
Loading

Issue

The env variable PORT is not set in the workflow which results in falling back on the .env file. This is a problem if we want to remove the .env file from the source control.

Expected

The GitHub workflows should not depend on the .env file.

Solution

add the PORT=80 env variable in the Build Docker Production and Deploy workflows in the following files:

  • .template/addons/github/.github/workflows/test_production_build.yml.tt
  • .template/addons/github/.github/workflows/deploy_heroku.yml.tt

Example:
image
@malparty malparty added this to the 5.3.0 milestone Sep 9, 2022
@malparty malparty removed this from the 5.3.0 milestone Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type : bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@malparty