Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect parsing with comments #39

Open
ray-holland-es opened this issue Oct 5, 2022 · 1 comment
Open

Incorrect parsing with comments #39

ray-holland-es opened this issue Oct 5, 2022 · 1 comment

Comments

@ray-holland-es
Copy link

I have a gradle with the following in it and it will not parse unless I remove the comments. It should parse correctly.

project.ext.react = [
    enableHermes: true,  // clean and rebuild if changing
    // hermesFlagsRelease: ["-w", "-O", "-output-source-map"],
    // hermesFlagsStaging: ["-w", "-O", "-output-source-map"],
    // hermesFlagsDebug: ["-w", "-O", "-output-source-map"],
    bundleInStaging: true,
    devDisabledInStaging: true,
    bundleInInternalTest: true,
    bundleInRelease: true,
    deleteDebugFilesForVariant: { // Resolves hermes related bug for variants https://github.com/facebook/react-native/issues/33177
        def v -> v.name.toLowerCase().contains('release') || v.name.toLowerCase().contains('staging')
    },
]
@karllindmark
Copy link
Contributor

Hi @ray-holland-es, sorry for the late response - these Github notifications end up somewhere I don't see them.

Anyways, this sure seems like a bug - the reasonable outcome here would indeed be that the comments are skipped and the parse completes OK.

Any chance you happen have time to provide a fix for the issue?

Thanks for sharing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants