Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Distinguish between surface and volume spaces in Reference #881

Open
tsalo opened this issue Jul 23, 2024 · 4 comments · May be fixed by #883
Open

Distinguish between surface and volume spaces in Reference #881

tsalo opened this issue Jul 23, 2024 · 4 comments · May be fixed by #883

Comments

@tsalo
Copy link
Contributor

tsalo commented Jul 23, 2024

What would you like to see added in this software?

In order to parse surface-volume combinations for CIFTIs, I think Reference needs to be able to distinguish between the surface space and the volume space.

This is related to nipreps/fmriprep#3330.

Do you have any interest in helping implement the feature?

Yes

Additional information / screenshots

No response

@tsalo
Copy link
Contributor Author

tsalo commented Jul 23, 2024

BEP 011 (Structural Derivatives) introduces a volspace entity that could be useful here.

EDIT: Unfortunately, at least one entity (cohort) could end up overloaded. For example, if I wanted to use dhcpAsym:cohort-42 as the surface space and MNIInfant:cohort-1 as the volume space, cohort ends up having two values (42 and 1) and no way to associate the values with the right templates. I think we'll need a volcohort entity to make it work.

@mgxd
Copy link
Contributor

mgxd commented Jul 23, 2024

I know it is not BIDS compliant, but this seems like a good argument for supporting the + character as a cohort extension to greatly simplify naming.

dhcpAsym+42, MNIInfant+1

@tsalo
Copy link
Contributor Author

tsalo commented Jul 23, 2024

That's a great point. I've been working on using volspace and volcohort in a branch, but the + character might be better.

@tsalo tsalo linked a pull request Jul 23, 2024 that will close this issue
@tsalo
Copy link
Contributor Author

tsalo commented Sep 20, 2024

It seems like folks would prefer to use +s in the space entity instead of adding new cohort, volspace, and volcohort entities. So something like "dhcpAsym:cohort-42 as the surface space and MNIInfant:cohort-1 as the volume space" would end up as space-dhcpAsym42+MNIInfant1.

Niworkflows is still going to need to parse space definitions that include the surface and volume spaces, so I think I can still move forward with #883.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants