-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
It appears "allowTabs" does not work #81
Comments
Ok, some very strange things are happening. The tab starts out saying "bash", but if I type a command, "Holy cow" say, and move to a different browser tab then back to the browser tab containing the terminal then where there was once "bash" it now says "Holy". This is a super simple app with nothing more than the Terminal.
Could be a bug in one of the dependencies. Here is the code - I'm using the pass though. import React, { Component } from 'react'; function App() {
return (
<Terminal
hideTopBar='true'
allowTabs='true'
startState="maximised"
color='green'
backgroundColor='black'
barColor='black'
style={{ fontWeight: "bold", fontSize: "1em", width: "100%" }}
commandPassThrough={cmd => {
return `You said ${cmd.join(' ')}! `
}}
msg='Hello World
/>
);
}
export default App; |
For now you can visit https://jloveric.github.io/ to see what I'm talking about as I have the terminal example running there. |
Try putting your boolean based variables within curly brackets, like this:
Otherwise React detects them as strings and not booleans. |
It seems the "allowTabs" option, setting to true or false does nothing? Whether it's set to true or false, you can still add new tabs. Also is there a way to get rid of the tab bar completely? I was thinking allowTabs would do that.
The text was updated successfully, but these errors were encountered: