Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not a clue #7

Open
seffw opened this issue Nov 13, 2016 · 3 comments
Open

Not a clue #7

seffw opened this issue Nov 13, 2016 · 3 comments

Comments

@seffw
Copy link

seffw commented Nov 13, 2016

Thanks for providing the plugin, but not a clue how to use it.

You demo is using a flickr stream it seems which gives no insight into how to get the image data into the your function.

I'm moving on because there are other options. I'd recommend making a demo which is replicable or the HTML + JS + CSS needed to make a working demo.

@candyflip19
Copy link

candyflip19 commented Dec 15, 2016

Same issue here

I also dislike that you have to link the pictures in the JS. Would be a better solution IMHO if the source of the pictures would be in the DOM in case of someone has disabled JS and SEO.

@santiagovdk
Copy link

Same here, no clue on how to implement it...

@mathiasuk
Copy link

There is also the option of inserting the pictures list in the page itself in a js variable so you don't need to fetch the images from an external source.
For example I use something like:

<script>
var photos = [{width: 4000, height: 3000, url: '/path/to/myfirst.jpg'}, {width: 2000, height: 2000, url: '/path/to/mysecond.jpg']
</script>

The content of the array can be pretty much anything you want as you can write your own getSize, thumbnailPath, template, etc. methods.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants