Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat:init hostels page #210

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

feat:init hostels page #210

wants to merge 2 commits into from

Conversation

heydoyouknowme0
Copy link
Contributor

No description provided.

Copy link
Member

@GetPsyched GetPsyched left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hostels not in db?

app/[locale]/hostels/[url_name]/page.tsx Outdated Show resolved Hide resolved
app/[locale]/hostels/page.tsx Outdated Show resolved Hide resolved
i18n/translations.ts Outdated Show resolved Hide resolved
@heydoyouknowme0
Copy link
Contributor Author

heydoyouknowme0 commented Aug 27, 2024

#208

Yes, this should have been linked already

@GetPsyched
Copy link
Member

Why is the deployment failing?

@heydoyouknowme0
Copy link
Contributor Author

Linting errors, left it cause I'll have to comment out a lot of things(cause of the missing schema, I'll rebase once the schema is merged

import { getTranslations } from '~/i18n/translations';
import { db, hostels } from '~/server/db';

export async function generateStaticParams() {
Copy link
Contributor Author

@heydoyouknowme0 heydoyouknowme0 Sep 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
should I change them to dynamic ?
@GetPsyched

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why does that error show up? Any reason?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's what i'm unsure about, other pages use same fetch pattern and dont seem to get this error

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants