feat/club events' schema #213
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GetPsyched
requested changes
Aug 30, 2024
server/db/schema/clubs.schema.ts
Outdated
Comment on lines
54
to
56
| clubMembers: many(clubMembers), | ||
| clubSocials: many(clubSocials), | ||
| clubEvents: many(events), |
There was a problem hiding this comment.
Suggested change
| clubMembers: many(clubMembers), | |
| clubSocials: many(clubSocials), | |
| clubEvents: many(events), | |
| clubEvents: many(events), | |
| clubMembers: many(clubMembers), | |
| clubSocials: many(clubSocials), |
This is alphabetically ordered
server/db/schema/events.schema.ts
Outdated
| description: varchar('description', { length: 512 }), | ||
| startDate: timestamp('date').notNull(), | ||
| endDate: timestamp('date').notNull(), | ||
| clubId: integer('club_id') |
There was a problem hiding this comment.
If this is a event specific to a club, name the table club_events
There was a problem hiding this comment.
An event may or may not be related to a club, such as a convocation
There was a problem hiding this comment.
Then make the club_id nullable.
server/db/schema/index.ts
Outdated
| @@ -20,3 +20,4 @@ export * from './sponsored-research-projects.schema'; | |||
| export * from './staff.schema'; | |||
| export * from './student-academic-details.schema'; | |||
| export * from './students.schema'; | |||
| export * from './events.schema'; | |||
There was a problem hiding this comment.
This file is also alphabetically ordered. And in light of the previous comment, this would be club-events.schema
GetPsyched
reviewed
Aug 31, 2024
server/db/schema/clubs.schema.ts
Outdated
Comment on lines
30
to
34
| howToJoinUs: varchar('how_to_join_us').notNull(), | ||
| whyToJoinUs: varchar('why_to_join_us').notNull(), | ||
| notifications: varchar('notifications') | ||
| .array() | ||
| .default(sql`'{}'`), |
There was a problem hiding this comment.
Do this in a different PR please
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.