Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

helix languages not generate proper toml, grammers not supported #3425

Closed
i-am-logger opened this issue Nov 18, 2022 · 4 comments
Closed

helix languages not generate proper toml, grammers not supported #3425

i-am-logger opened this issue Nov 18, 2022 · 4 comments

Comments

@i-am-logger
Copy link

languages = mkOption {

languages = [
  { 
    name = "nix";
    language-server = { command = "nil"; };
];

is generated to

[[language]]
name = "nix"
[language.language-server]
command = "nil"

correct behavior should generate the following toml

[[language]]
name = "nix"
language-server = { command = "nil" }

in addition, there is no way to declare a grammer

should generate a proper toml similar to below

[[language]]
name = "nix"
scope = "source.nix"
injection-regex = "nix"
file-types = ["nix"]
shebangs = []
roots = []
auto-format = true
formatter = { command = "nixpkgs-fmt" }
comment-token = "#"
language-server = { command = "nil" }
indent = { tab-width = 2, unit = "  " }

[[grammar]]
name = "nix"
source = { git = "https://github.com/cstrahan/tree-sitter-nix", rev = "1b69cf1fa92366eefbe6863c184e5d2ece5f187d" }      
@i-am-logger i-am-logger changed the title languages not generate proper toml, grammers not supported helix languages not generate proper toml, grammers not supported Nov 18, 2022
@i-am-logger
Copy link
Author

@Philipp-M will appreciate your input on how to fix this.

@Philipp-M
Copy link
Contributor

The first part (TOML generation) is I think a duplicate of #2907 and #3299

The support for custom grammars I think this is a duplicate of #2871, isn't it?

@i-am-logger
Copy link
Author

i-am-logger commented Nov 18, 2022

Yes, seems it is duplicates

@stale
Copy link

stale bot commented Feb 17, 2023

Thank you for your contribution! I marked this issue as stale due to inactivity. Please be considerate of people watching this issue and receiving notifications before commenting 'I have this issue too'. We welcome additional information that will help resolve this issue. Please read the relevant sections below before commenting.

If you are the original author of the issue

  • If this is resolved, please consider closing it so that the maintainers know not to focus on this.
  • If this might still be an issue, but you are not interested in promoting its resolution, please consider closing it while encouraging others to take over and reopen an issue if they care enough.
  • If you know how to solve the issue, please consider submitting a Pull Request that addresses this issue.

If you are not the original author of the issue

  • If you are also experiencing this issue, please add details of your situation to help with the debugging process.
  • If you know how to solve the issue, please consider submitting a Pull Request that addresses this issue.

Memorandum on closing issues

Don't be afraid to manually close an issue, even if it holds valuable information. Closed issues stay in the system for people to search, read, cross-reference, or even reopen – nothing is lost! Closing obsolete issues is an important way to help maintainers focus their time and effort.

@stale stale bot added the status: stale label Feb 17, 2023
@ncfavier ncfavier closed this as not planned Won't fix, can't repro, duplicate, stale Feb 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants