Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feh module - Create a program.package option #3495

Closed
Dioprz opened this issue Dec 14, 2022 · 6 comments
Closed

Feh module - Create a program.package option #3495

Dioprz opened this issue Dec 14, 2022 · 6 comments
Assignees

Comments

@Dioprz
Copy link
Contributor

Dioprz commented Dec 14, 2022

Description

Because feh can extend their capabilities by adding a full imlib2 library (i.e. support for .heic, .svg, etc), I had to disable the module to install a overrided feh package with the changes. So I want to ask if makes sense to add an program.feh.package option to the feh module for this?

I remain attentive to what you think, and thanks in advance.

@rycee
Copy link
Member

rycee commented Dec 18, 2022

If you make a PR that adds such an option then I'm pretty certain it would be accepted. See, e.g., #3456.

@Dioprz
Copy link
Contributor Author

Dioprz commented Dec 25, 2022

Hello again.

I am trying to test that the option (added in home-manager/modules/programs/feh.nix) works correctly, however when I try to test it I get the following error.

error: The option `programs.feh.package' does not exist. Definition values:
       - In `/nix/store/6l7czsqbmabj43msi8ic2ydd9566vqng-source/home-manager/home.nix': <derivation feh-3.9>
(use '--show-trace' to show detailed location information)

To run my local copy of home-manager I have tried the two options mentioned in the contribution guide. However neither works. To be exact I am running

home-manager -I home-manager=/home/user/dev/home-manager switch --flake <path_to_my_flake>

I suspect that the flake inputs are overwriting the flag used in the command, but I'm not sure and if so I don't know how to correct it. Could you direct me how I can fix the error please?

@Dioprz Dioprz mentioned this issue Jan 2, 2023
7 tasks
@ncfavier
Copy link
Member

ncfavier commented Jan 2, 2023

With --flake, you probably want to use something like home-manager --override-input home-manager /home/user/dev/home-manager. Can you confirm that this works?

This should probably be added to the documentation.

@ncfavier
Copy link
Member

ncfavier commented Jan 2, 2023

Closed by #3552

@ncfavier ncfavier closed this as completed Jan 2, 2023
@Dioprz
Copy link
Contributor Author

Dioprz commented Jan 2, 2023

With --flake, you probably want to use something like home-manager --override-input home-manager /home/user/dev/home-manager. Can you confirm that this works?

Yes sir, I just did it and it works perfectly. The complete command to execute is then:

home-manager --override-input home-manager <path_to_local_home-manager> switch --flake <path_to_flake>.

This should probably be added to the documentation.

It would be nice. I just thought of changing the url in the flake input directly and this solution is much simpler.

Thanks for your help.

@ncfavier
Copy link
Member

ncfavier commented Jan 2, 2023

#3556

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants