This repository has been archived by the owner on Jan 30, 2023. It is now read-only.
Shorten the paths, rename to package.nix #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also it opens up |
blaggacao
reviewed
Nov 2, 2022
README.md
Outdated
Comment on lines
116
to
126
| - Use `package.nix` instead of `package-function.nix` | ||
| - Makes the migration to a non-function form of overridable packages harder in the future. We'd like to use `package.nix` for a package format that's based on a fixpoint rather than a function, because that will make overriding simpler. | ||
|
|
||
| - Use `default.nix` instead of `package-function.nix` | ||
| - `default.nix`'s only benefits do not apply | ||
| - removing the need to specify the file name in expressions, but this does not apply because we have to do this at most once in the code that replaces definitions from `all-packages.nix`. | ||
| - removing the need to specify the file name on the command line, but this does not apply because a package function must be imported into an expression before it can be used, making `nix build -f pkg/hello` equally broken regardless of file name. | ||
| - Choosing `default.nix` would bias the purpose of the `pkg` directory to serve only as package definitions, whereas we could make the tree more human friendly by grouping files together by "topic" rather than by technical delineations. For instance, having a package definition, changelog, package-specific config generator and perhaps even NixOS module in one directory makes work on the package in a broad sense easier. This is not a goal of this RFC, but a motivation to make this a future possibility. |
|
How about |
Sounds fun 👍 |
The shorter layout is slightly easier to use. By using `package.nix` we clarify the purpose and format of the expression file, and open up to the possibility of moving towards a human-centric _functional_ tree instead of a tree based on technical features. In order words, be forwards compatible with https://github.com/nixpkgs-architecture/issues/issues/5#issuecomment-1228656788 so that that could be implemented with minimal maintenance impact.
roberth
force-pushed
the
improve-paths
branch
from
cd13ba5
to
08d5a32
Compare
infinisil
approved these changes
Nov 14, 2022
|
We discussed this in the meeting today: https://discourse.nixos.org/t/2022-11-14-nixpkgs-architecture-team-meeting-17/23172/2#auto-called-packages-rfc-draft-review-3 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The shorter layout is slightly easier to use.
By using
package.nixwe clarify the purpose and format of the expression file, and open up to the possibility of moving towards a human-centric functional tree instead of a tree based on technical features. In order words, be forwards compatible with https://github.com/nixpkgs-architecture/issues/issues/5#issuecomment-1228656788 so that that could be implemented with minimal maintenance impact.Closes #3
Closes #6