From b3d0e5255c4d61d653c7b45b6e2a3793ac666486 Mon Sep 17 00:00:00 2001 From: Sebastien VERDET Date: Tue, 5 Mar 2024 10:34:49 +0100 Subject: [PATCH 1/3] fix shellcheck warnings --- bin/install | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/bin/install b/bin/install index 4f9f9f0..52e8427 100755 --- a/bin/install +++ b/bin/install @@ -51,8 +51,8 @@ get_platform() { local machine_hardware_name machine_hardware_name=${ASDF_KUBECTL_OVERWRITE_ARCH:-"$(uname -m)"} - version_short=$(echo ${version}|sed -e 's/^v//') - version_split=( ${version_short//./ } ) + version_short="${version//v/""}" + version_split=( "${version_short//./ }" ) case "$machine_hardware_name" in 'x86_64') local cpu_type="amd64" ;; 'aarch64') local cpu_type="arm64" ;; @@ -61,9 +61,9 @@ get_platform() { esac # Work around arch type on filenames after 0.11.2 - if [ "${cpu_type}" == "amd64" ] && [ ${version_split[0]} -eq 0 ] && [ ${version_split[1]} -le 11 ]; then + if [ "${cpu_type}" == "amd64" ] && [ "${version_split[0]}" -eq 0 ] && [ "${version_split[1]}" -le 11 ]; then cpu_type="x86_64" - if [ ${version_split[1]} -eq 11 ] && [ ${version_split[2]} -gt 1 ]; then + if [ "${version_split[1]}" -eq 11 ] && [ "${version_split[2]}" -gt 1 ]; then cpu_type="amd64" fi fi From a81e75b840a2fafbb50f9687d7298a44abcb6117 Mon Sep 17 00:00:00 2001 From: Sebastien VERDET Date: Tue, 2 Apr 2024 09:29:57 +0200 Subject: [PATCH 2/3] add shellcheck exclusion --- bin/install | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/bin/install b/bin/install index 52e8427..ee3b61c 100755 --- a/bin/install +++ b/bin/install @@ -52,7 +52,8 @@ get_platform() { local machine_hardware_name machine_hardware_name=${ASDF_KUBECTL_OVERWRITE_ARCH:-"$(uname -m)"} version_short="${version//v/""}" - version_split=( "${version_short//./ }" ) + # shellcheck disable=SC2206 + version_split=( ${version_short//./ } ) case "$machine_hardware_name" in 'x86_64') local cpu_type="amd64" ;; 'aarch64') local cpu_type="arm64" ;; From bacde140e21409a82fa388e08981af61bd8bdb43 Mon Sep 17 00:00:00 2001 From: Sebastien VERDET Date: Tue, 2 Apr 2024 09:39:21 +0200 Subject: [PATCH 3/3] try upgrade plugin-test action --- .github/workflows/workflow.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/workflow.yml b/.github/workflows/workflow.yml index b2db98a..27746e0 100644 --- a/.github/workflows/workflow.yml +++ b/.github/workflows/workflow.yml @@ -18,7 +18,7 @@ jobs: steps: - name: asdf_plugin_test - uses: asdf-vm/actions/plugin-test@v1.0.0 + uses: asdf-vm/actions/plugin-test@v2.0.0 with: version: ${{ matrix.popeye }} command: popeye version