Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Culture option to ${aspnet-item} and {aspnet-session} #123

Merged
merged 6 commits into from
Mar 31, 2017
Merged

Added Culture option to ${aspnet-item} and {aspnet-session} #123

merged 6 commits into from
Mar 31, 2017

Conversation

sbebrys
Copy link

@sbebrys sbebrys commented Mar 30, 2017

Correct use configured culture in HttpContext Items and SessionId

Sebastian Bebrys added 3 commits March 30, 2017 09:34
Correct use configured culture in HttpContext Items and SessionId
@304NotModified
Copy link
Member

I see appVeyor uses "Microsoft (R) Build Engine version 14.0.25420.1". Is this still correct?

@sbebrys
Copy link
Author

sbebrys commented Mar 30, 2017

For aspnetcore appVeyor used "Microsoft (R) Build Engine version 15.1.548.43366", so I try with force correct version of sdk net core in missed global.json

@304NotModified
Copy link
Member

👍

I think the title should be: "Added Culture option to ${aspnet-item} and {aspnet-session}"? (it's a feature instead of a bug)

@sbebrys sbebrys changed the title Correct use configured culture Added Culture option to ${aspnet-item} and {aspnet-session} Mar 30, 2017
@304NotModified
Copy link
Member

:( build still broken

@sbebrys
Copy link
Author

sbebrys commented Mar 30, 2017

Now globals will be ok :)

@sbebrys
Copy link
Author

sbebrys commented Mar 30, 2017

Ok, NetCore version is ready to go ;)

@codecov-io
Copy link

Codecov Report

Merging #123 into master will increase coverage by 1.39%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #123      +/-   ##
==========================================
+ Coverage   57.67%   59.07%   +1.39%     
==========================================
  Files          24       24              
  Lines         293      303      +10     
  Branches       75       75              
==========================================
+ Hits          169      179      +10     
  Misses         90       90              
  Partials       34       34
Impacted Files Coverage Δ
...e/LayoutRenderers/AspNetItemValueLayoutRenderer.cs 87.5% <100%> (+5.68%) ⬆️
...ayoutRenderers/AspNetSessionValueLayoutRenderer.cs 86.66% <100%> (+6.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c8176a4...c9292d7. Read the comment docs.

@304NotModified 304NotModified added this to the 4.3.3 - Web.AspNetCore milestone Mar 30, 2017
@304NotModified
Copy link
Member

thanks!

before merging this, I see that the author of your commits is wrong. Like to fix that, or don't care?

image

@sbebrys
Copy link
Author

sbebrys commented Mar 31, 2017

Don't care :-)

@304NotModified 304NotModified merged commit 2ab8049 into NLog:master Mar 31, 2017
@304NotModified
Copy link
Member

OK! Merged then!

@304NotModified
Copy link
Member

thanks for fixing the build!

@304NotModified 304NotModified added ASP.NET Core ASP.NET 4 ASP.NET MVC Classic labels Mar 31, 2017
@snakefoot snakefoot added ASP.NET Core ASP.NET Core - all versions and removed ASP.NET Core 1 labels Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ASP.NET Core ASP.NET Core - all versions ASP.NET 4 ASP.NET MVC Classic feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants