-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Culture option to ${aspnet-item} and {aspnet-session} #123
Conversation
Correct use configured culture in HttpContext Items and SessionId
I see appVeyor uses "Microsoft (R) Build Engine version 14.0.25420.1". Is this still correct? |
For aspnetcore appVeyor used "Microsoft (R) Build Engine version 15.1.548.43366", so I try with force correct version of sdk net core in missed global.json |
👍 I think the title should be: "Added Culture option to ${aspnet-item} and {aspnet-session}"? (it's a feature instead of a bug) |
:( build still broken |
Now globals will be ok :) |
Ok, NetCore version is ready to go ;) |
Codecov Report
@@ Coverage Diff @@
## master #123 +/- ##
==========================================
+ Coverage 57.67% 59.07% +1.39%
==========================================
Files 24 24
Lines 293 303 +10
Branches 75 75
==========================================
+ Hits 169 179 +10
Misses 90 90
Partials 34 34
Continue to review full report at Codecov.
|
Don't care :-) |
OK! Merged then! |
thanks for fixing the build! |
Correct use configured culture in HttpContext Items and SessionId