Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

${aspnet-request-ip} handle emtpy Request on HttpContext #275

Merged
merged 1 commit into from
Apr 12, 2018

Conversation

304NotModified
Copy link
Member

Fixes #274

@304NotModified 304NotModified added bug ASP.NET 4 ASP.NET MVC Classic labels Apr 12, 2018
@304NotModified 304NotModified added this to the NLog.Web 4.5.3 milestone Apr 12, 2018
@codecov
Copy link

codecov bot commented Apr 12, 2018

Codecov Report

Merging #275 into master will decrease coverage by <1%.
The diff coverage is 0%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #275    +/-   ##
======================================
- Coverage      57%    57%   -<1%     
======================================
  Files          31     31            
  Lines         407    407            
  Branches       92     92            
======================================
- Hits          233    231     -2     
  Misses        138    138            
- Partials       36     38     +2
Impacted Files Coverage Δ
...e/LayoutRenderers/AspNetRequestIpLayoutRenderer.cs 0% <0%> (ø) ⬆️
...youtRenderers/AspNetRequestCookieLayoutRenderer.cs 80% <0%> (-4%) ⬇️
...outRenderers/AspNetLayoutMultiValueRendererBase.cs 96% <0%> (-2%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 37b2d5f...40ed97d. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ASP.NET 4 ASP.NET MVC Classic bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant