Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issued with Clion Inspection Resolution since 2018.1 #1033

Closed
trivigy opened this issue Apr 1, 2018 · 8 comments
Closed

Issued with Clion Inspection Resolution since 2018.1 #1033

trivigy opened this issue Apr 1, 2018 · 8 comments
Labels
solution: proposed fix a fix for the issue has been proposed and waits for confirmation

Comments

@trivigy
Copy link

trivigy commented Apr 1, 2018

Really not sure how to touch base with clion nor do I feel like they will do anything to fix this. Figured I will post it here and see if anyone else has the same issue.

In both cases I am getting: "no matching function" and "no matching constructor".

However the code compiles and works fine.
screenshot from 2018-04-01 10-48-56
screenshot from 2018-04-01 10-48-45

@nlohmann
Copy link
Owner

nlohmann commented Apr 1, 2018

This is strange. But CLion seems to have some issues with templates. It keeps proposing to "optimize" the code by removing SFINAE guards. I am not sure whether CLion has a bug tracker, but I think opening an issue there could help.

@trivigy
Copy link
Author

trivigy commented Apr 3, 2018

Raised an issue on clion board. Hopefully someone on their end will look into this. One other thing I mentioned was that I noticed an update in clang version along with the upgrade to clion-2018.1. Could it be related to clang changing something? I believe inspection is done using clang, I may be wrong on that one though.

https://youtrack.jetbrains.com/issue/CPP-12558

@nlohmann
Copy link
Owner

nlohmann commented Apr 3, 2018

Thanks for reporting! If the inspection worked before, then it could really be a Clang bug as well.

@nlohmann
Copy link
Owner

nlohmann commented Apr 3, 2018

The issue could be fixed with CLion 2018.1.1 EAP, see https://youtrack.jetbrains.com/issue/CPP-12558.

@nlohmann nlohmann added the solution: proposed fix a fix for the issue has been proposed and waits for confirmation label Apr 3, 2018
@trivigy
Copy link
Author

trivigy commented Apr 3, 2018

I can confirm that it fixes it partially. My guess that this will get totally fixed in the next release. I also was right, this has to do with clang-tidy. I can see a slightly different issue now but I will keep following up on this with the jetbrains team. This thread can probably be closed.
screenshot from 2018-04-03 12-07-09

@trivigy trivigy closed this as completed Apr 3, 2018
@nlohmann
Copy link
Owner

nlohmann commented Apr 3, 2018

Thanks a lot for reporting! I'll do my best that this library can serve as a benchmark for Jetbrains ;-)

@trivigy
Copy link
Author

trivigy commented Apr 3, 2018

@nlohmann Don't be harsh on yourself. You are already doing an absolutely amazing job. I tried tons of json libraries and finally stuck with this because of the awesome syntax you made work. I am sure implementing that was not easy. So, it is bound to have some issues with the jetbrains coding style and expectations.

@OvermindDL1
Copy link

For note, I tried the code in KDevelop (which also embeds clang) and it did not have such issues, so it's not a clang thing. :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
solution: proposed fix a fix for the issue has been proposed and waits for confirmation
Projects
None yet
Development

No branches or pull requests

3 participants