Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repository is almost 450MB #1497

Closed
toomanybananas opened this issue Feb 28, 2019 · 1 comment · Fixed by #2081
Closed

Repository is almost 450MB #1497

toomanybananas opened this issue Feb 28, 2019 · 1 comment · Fixed by #2081
Assignees
Labels
release item: 🔨 further change solution: duplicate the issue is a duplicate; refer to the linked issue instead solution: proposed fix a fix for the issue has been proposed and waits for confirmation
Milestone

Comments

@toomanybananas
Copy link

The size of this repository is 436MB unpacked (although the download is 'only' ~150MB), which is insane for a tiny JSON parsing library. There are multiple cases where (IMO) the size can be trimmed down massively without actually impacting the repo.

The .git directory is 178MB, likely since you have a lot of changed binary files. You can easily slash the size of this directory by ~90% using git repack (which has drawbacks for repo history, but unless you really care about specific info about changes from years ago this is fine).

Why do you have a 23MB file of 1000000 signed integers in test/data/regression/signed_ints.json Do any of those ints besides the first few thousand really contribute any code coverage? I'd wager not. If the purpose of that many is to make sure the program can handle really large JSON files, why is there also another 23MB of unsigned integers? And 22MB of floats? Having lots of tests is good but this is seriously affecting users with slow internet speed who want to contribute to the project.

@nlohmann
Copy link
Owner

Duplicate of #96.

@nlohmann nlohmann added the solution: duplicate the issue is a duplicate; refer to the linked issue instead label Feb 28, 2019
@nlohmann nlohmann reopened this May 4, 2020
@nlohmann nlohmann linked a pull request May 4, 2020 that will close this issue
@nlohmann nlohmann self-assigned this May 4, 2020
@nlohmann nlohmann added release item: 🔨 further change solution: proposed fix a fix for the issue has been proposed and waits for confirmation labels May 4, 2020
@nlohmann nlohmann added this to the Release 3.8.0 milestone May 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release item: 🔨 further change solution: duplicate the issue is a duplicate; refer to the linked issue instead solution: proposed fix a fix for the issue has been proposed and waits for confirmation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants