Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unnecessary test data file in the release #1790

Closed
aaquant opened this issue Oct 14, 2019 · 5 comments · Fixed by #2081
Closed

Unnecessary test data file in the release #1790

aaquant opened this issue Oct 14, 2019 · 5 comments · Fixed by #2081
Assignees
@nlohmann
Labels
kind: enhancement/improvement release item: 🔨 further change solution: proposed fix a fix for the issue has been proposed and waits for confirmation
Milestone
Release 3.8.0

Comments

@aaquant
Copy link

aaquant commented Oct 14, 2019

The total repo exceeds 200MB in size.
An ordinary user of this library doesn't need those data or test output data file.
Please do not include those files in the release branch, some examples are:

test/data
test/reports
benchmark/data

Those files are needed by developers of this project.

Without those files, the size of the repo can be reduced to 2.6MB.
@aaquant aaquant changed the title Unnecessary test data file in the git repo Unnecessary test data file in the release Oct 14, 2019
@gregmarr
Copy link
Contributor

Duplicate of #96.

@stale
Copy link

stale bot commented Nov 13, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the state: stale the issue has not been updated in a while and will be closed automatically soon unless it is updated label Nov 13, 2019
@jeffreyscottgraham
Copy link

I for one was waiting for this improvement. I don't understand how it is stale, since the change must happen by the repo owner? Or are you wanting a PR ?

@stale stale bot removed the state: stale the issue has not been updated in a while and will be closed automatically soon unless it is updated label Nov 14, 2019
@nlohmann
Copy link
Owner

Sorry, I did not find the time to work on this.

@stale
Copy link

stale bot commented Dec 14, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the state: stale the issue has not been updated in a while and will be closed automatically soon unless it is updated label Dec 14, 2019
@stale stale bot closed this as completed Dec 21, 2019
@nlohmann nlohmann reopened this May 4, 2020
@stale stale bot removed the state: stale the issue has not been updated in a while and will be closed automatically soon unless it is updated label May 4, 2020
@nlohmann nlohmann linked a pull request May 4, 2020 that will close this issue
Use external test data #2081
Merged
@nlohmann nlohmann mentioned this issue May 4, 2020
Merged
@nlohmann nlohmann self-assigned this May 4, 2020
@nlohmann nlohmann added release item: 🔨 further change solution: proposed fix a fix for the issue has been proposed and waits for confirmation labels May 4, 2020
@nlohmann nlohmann added this to the Release 3.8.0 milestone May 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nlohmann nlohmann

Labels
kind: enhancement/improvement release item: 🔨 further change solution: proposed fix a fix for the issue has been proposed and waits for confirmation
Projects
None yet
Milestone
Release 3.8.0
Development

Successfully merging a pull request may close this issue.

Use external test data nlohmann/json
4 participants
@nlohmann @jeffreyscottgraham @gregmarr @aaquant