Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UFS-Coastal/FVCOM Inclusion: Development/Testing/Consulation #177

Open
pvelissariou1 opened this issue Jun 13, 2023 · 6 comments
Open

UFS-Coastal/FVCOM Inclusion: Development/Testing/Consulation #177

pvelissariou1 opened this issue Jun 13, 2023 · 6 comments
Assignees

Comments

@pvelissariou1
Copy link
Collaborator

pvelissariou1 commented Jun 13, 2023

Support of inclusion of FVCOM into UFS-Coastal. Three tasks are defined for this project:

  • Development: Contributions to the FVCOM repository in the model's source code and in the NUOPC code, to ensure flawless integration in CoastalApp and in the transitioned UFS-Coastal application.
  • Testing: Run UFS-Coastal/FVCOM based regression tests on Orion, Hera and ParallelWorks (in that order) to verify the integrity of the system. Comparisons/Analyses with real data is a requirement.
  • Consultation: Offer consultation to both FVCOM and NCAR developers on FVCOM internals, compilation and model requirements (e.g., libraries, compilers, etc).

Related Issues: CoastalApp test suite #150

@pvelissariou1 pvelissariou1 self-assigned this Jun 13, 2023
@pvelissariou1
Copy link
Collaborator Author

Submitted a PR to FVCOM repo for the updates to the source tree. On 06/22/2023 the PR will be reviewed and merged into the main branch.
FVCOM compiles as expected within CoastalApp as expected, tests also passed.
Jianhua is working on a barotropic test case for ATMESH+FVCOM upon my request. A 2D case ATMESH+FVCOM+WW3 will follow.

@saeed-moghimi-noaa
Copy link
Collaborator

Please update

@saeed-moghimi-noaa
Copy link
Collaborator

saeed-moghimi-noaa commented Nov 20, 2023

@pvelissariou1 @janahaddad

Hi Takis,

Please make sure to coordinate with the project team here before accepting any tasks from model developers specific to models and not directly related to the UFS-Coastal.

Again I want to repeat the process in which we should work with the Model Developers in general:

We at the NOS Storm Surge Modeling Team in collaboration with NCAR team will continue supporting integration of new developments and upgrades of FVCOM and other models (model, cap, ....) that are shared with us into the UFS-Coastal code base through:

  1. github pull requests
  2. by providing appropriate Regression Tests (RT).

@pvelissariou1
Copy link
Collaborator Author

Thanks @saeed-moghimi-noaa I totally agree. There are occassions though that we might need to provide some additional support in order to move forward in UFS-Coastal, as in the case of the julian library in FVCOM. I think I have already provided enough consultation to FVCOM folks so far, they now need to provide us with the required RTs to go to the next stage.

@pvelissariou1
Copy link
Collaborator Author

FVCOM in UFS-Coastal is on hold at this moment. Waiting from the developers for:

  1. Fix the issue with the FVCOM required libraries (Julian). They need to incorporate the library into the FVCOM source os in the build process
  2. Supply a 2D test case for FVCOM coupled with WW3

Notes:

  1. The sources of WW3 should not be modified, instead need to submit a PR to WW3 developers for the required changes/modifications. In general, WW3 needs to export additional wave variables necessary to calculate the 3D wave induced terms in the various ocean models (we should have a discussion about this)
  2. FVCOM's NUOPC cap needs cleanup, some rewrtting and improvements to support both 2D and 3D calculations

@pvelissariou1
Copy link
Collaborator Author

Meeting minutes (Fwd: FVCOM Development Tag up Meeting, March 20, 2024)
(From: Zizang Yang)

Please find below a brief summary of today's FVCOM Development Tag-up Meeting:

  • The UMass team works on enhancing the efficiency of the FVCOM code by updating numerical schemes, particularly the "advection term".

  • The team completed a two-year simulation of an offshore windfarm project funded by the coastguard. This simulation incorporated two-way air-sea coupling using the non-hydrostatic mode of the FVCOM model, with a high grid resolution of up to 1 meter.

  • Significant progress has been made in fully coupling the FVCOM with the National Water Model. Key highlights of this effort include

    • a creative approach to handling coupling dynamics along segments rather than traditional point-focused methods,
    • dynamic determination of coupling regimes based on river discharge magnitude
    • calculation of river temperature considering both surface air temperature and bottom soil temperature (in collaboration with the UNH team)
    • incorporation of inland hydrology considerations.
  • NUOPC

    • Takis provided updates on the team's progress in Wave (WW3) and Ocean coupling. Discussions with the WW3 team are underway to expand export fields for the coupling WAVE+OCN.

NOTES by P.V

  • In this meeting I did not mention any tasks required by the FVCOM developers to bring FVCOM in UFS-Coastal (contributions on: RTs, model source code and NUOPC/ESMF modifications, etc.)
  • Asked them to contribute to the ww3 export fields document
  • Prof. Chen asked to help, via CoastalApp, to help resolve the known issues in their cluster. I explained that at this point further development of CoastalApp is halted.
  • It seems that they are doing some direct coupling work between NWM and FVCOM (not clear if they run NWM or just using NWM data)
  • Neither Ufuk or myself went any further to talk about UFS-Coastal/FVCOM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants