Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

base_shape input to GeomCollector extends the domain #135

Open
SorooshMani-NOAA opened this issue Feb 2, 2024 · 1 comment
Open

base_shape input to GeomCollector extends the domain #135

SorooshMani-NOAA opened this issue Feb 2, 2024 · 1 comment
Assignees

Comments

@SorooshMani-NOAA
Copy link
Collaborator

Base shape input for collector-type geometry object is supposed to clip off excess of domain, however right now it adds to the domain if pars of it fall outside of the input rasters:

image

@SorooshMani-NOAA SorooshMani-NOAA self-assigned this Feb 2, 2024
@SorooshMani-NOAA
Copy link
Collaborator Author

The issue seems to be due to the fact that the base shape is taken as the "exterior boundary" in the combine_geom logic:

if base_mult_poly:
# NOTE: This needs to happen once and before any
# modification to basemesh happens (due to overlap
# w/ DEM, etc.). Exterior of base mesh is used for
# raster clipping
#
# TODO: Add buffer for base mesh exterior in case there
# was erosion and we want to make sure new DEMs futher
# inland are considered (?)
self._base_exterior = MultiPolygon(
list(ops.polygonize(
[poly.exterior for poly in base_mult_poly.geoms])))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant