Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split native addon into its own package #15

Open
mhofman opened this issue Apr 22, 2019 · 1 comment
Open

Split native addon into its own package #15

mhofman opened this issue Apr 22, 2019 · 1 comment

Comments

@mhofman
Copy link

mhofman commented Apr 22, 2019

I've found the ObjectInfo and WeakTag concepts to be very powerful building blocks and used them directly in my shim for the WeakRefs proposal.

For this I am however directly loading the internal native bindings of your package, skipping the JS wrapper. Would you consider splitting your package in 2, and create a "native only" package that simply exports the native API?

@mhofman
Copy link
Author

mhofman commented May 3, 2019

For the time being I've extracted the loading of the internal bindings of this package into its own package and published https://www.npmjs.com/package/@mhofman/weak-napi-native.

I needed it to avoid mixing CommonJS and ESM in the same package :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant