-
-
Notifications
You must be signed in to change notification settings - Fork 682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Should the filename pass to this._newFile also be renamed if this.options.filename === 'function' ? #671
Comments
I'm not very sure what you are trying. I kind of sense what's the problem.. This option is more like "renaming the disk filepath" which.. works on "persistent mode", but not that much on volatile/exernal storage. |
Thank you for the prompt reply. |
I understand. But it'a nor possible now I think. We should think something or better option.
I guess you can, yes. I don't see problem. |
I think we should pass |
+1, why don't we pass the whole object to |
Support plan
Enterprise): Community
Context
What are you trying to achieve or the steps to reproduce?
In examples/store-files-on-s3.js, the filename received by uploadStream is still the part.filename since its the filename pass into this._newFile (
formidable/src/Formidable.js
Line 302 in 69b9a6e
Not sure its designed by intention or not
What was the result you got?
origin filename
What result did you expect?
renamed filename if option.filename exists
The text was updated successfully, but these errors were encountered: